Bugfix: fix handle poolcoordinator certificates in case of restarting… #1187
Conversation
… yurt-controller-manager
|
Welcome @batthebee! It looks like this is your first PR to openyurtio/openyurt 🎉 |
|
If you want to make a short test, here is the latest image: |
Codecov Report
@@ Coverage Diff @@
## master #1187 +/- ##
==========================================
+ Coverage 52.16% 52.20% +0.04%
==========================================
Files 110 110
Lines 13848 13852 +4
==========================================
+ Hits 7224 7232 +8
+ Misses 5977 5973 -4
Partials 647 647
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@batthebee Thank you for posting pull request to fix bug. It looks like that unit tests coverage is not enough, how about add some unit tests for changed code? |
|
/backport release-v1.2 |
|
Only merged pull requests can be backported. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: batthebee, luc99hen, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/backport release-v1.2 |
|
/backport release-v1.2 |
|
Successfully created backport PR #1193 for |
What type of PR is this?
/kind bug
What this PR does / why we need it:
as mentioned in #1182 there is an issue, when restarting
yurt-controller-manger.The
pool-coordinator-dynamic-certssecret doesn't contain127.0.0.1as valid destination, which causes errors on pool-coordinators etcd.Which issue(s) this PR fixes:
Fixes only some parts of #1182
Special notes for your reviewer:
There were two problems. The first one was, that the configuration containing the
127.0.0.1was overwritten by theinitmethod. The second one was to compare an array withnet.IPs bydeepEqual.Does this PR introduce a user-facing change?
None